From f556f17cce34c74222a79bec115e1aea8c34ac50 Mon Sep 17 00:00:00 2001
From: Kristy Fournier <124598538+kristy-fournier@users.noreply.github.com>
Date: Wed, 11 Feb 2026 09:36:19 -0500
Subject: [PATCH] Few fixes that i'm going to un-re-fix later

---
 Client/scripts.js   | 11 ++++++-----
 Server/webbyBits.py |  4 +---
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/Client/scripts.js b/Client/scripts.js
index 5cb324c..a330653 100644
--- a/Client/scripts.js
+++ b/Client/scripts.js
@@ -148,7 +148,7 @@ async function controlButton(buttonType) {
         document.getElementById("songlist-mode").style.display = "none";
         document.getElementById("settings-mode").style.display = "block";
         checkSettings()
-    } else if (buttonType = "pm") { //Partymode toggle (in settings)
+    } else if (buttonType == "pm") { //Partymode toggle (in settings)
         let response = await getFromServer({setting: "partymode-toggle"}, "settings")
         if(response.ok) {
             justChangedSetting = true;
@@ -156,6 +156,8 @@ async function controlButton(buttonType) {
         } else {
             // dont think anything is needed here
         }
+    } else {
+        alertText("Error: You pushed a button that does not exist");
     }
     
 
@@ -617,8 +619,7 @@ document.getElementById("settings-mode").style.display = "none";
 document.getElementById("volumerange").onchange = async function(e) {
     // there is no reason for this not to be a defined function
     // FIX THIS
-    console.log(e);
-    let returnValue = await getFromServer({setting:"volume",level:this.value}, "settings")
+    let returnValue = await getFromServer({setting:"volume",level:e.target.value}, "settings")
     if (returnValue["status"] == ERR_NO_ADMIN) {
         // alertText("Error: Admin restricted action");
         // there's an admin restrict alert built into getFromServer
@@ -718,9 +719,9 @@ socket.on("skipSong",() => {
 })
 
 socket.on("settingsChange",(data) => {
-    console.log(data);
+    // console.log(data);
     if(justChangedSetting) {
-        console.log("working");
+        // console.log("working");
         justChangedSetting = false;
     } else {
         // checkSettings();
diff --git a/Server/webbyBits.py b/Server/webbyBits.py
index 8342e75..25e245b 100644
--- a/Server/webbyBits.py
+++ b/Server/webbyBits.py
@@ -193,9 +193,7 @@ def settingsControl():
                     if(volumePassed == 0):
                         # only emit a signal i the volume really changed
                         socketio.emit("settingsChange",{"settingToChange":"volume","newData":volumeLevel})
-                        return {"error":"ok","data":{"volumePassed":volumePassed}},200
-                    else:
-                        return {"error":"VLC cannot take volume change requests at this time","data":None},500
+                    return {"error":"ok","data":{"volumePassed":volumePassed}},200
                 else:
                     return {"error":"Invalid volume level","data":None},422
             else: